-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21066] Carbon tracker integration #46
base: main
Are you sure you want to change the base?
Conversation
c1d6348
to
912c1c4
Compare
I think we need |
30dd1b2
to
b3742d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the tests fail because of a division by zero
, we should double check why it is happening, probably because we are using some dummy data
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
This reverts commit eaf414c.
b3742d1
to
3008c2d
Compare
The only possible division by zero is covered here |
Signed-off-by: eProsima <[email protected]>
3008c2d
to
08b19d3
Compare
Signed-off-by: Mario Dominguez <[email protected]>
f47c4e8
to
a471adf
Compare
Signed-off-by: Mario Dominguez <[email protected]>
a471adf
to
01d01c1
Compare
@Snailed, it seems that the github ci platform is not supported by the carbontracker as this error is being thrown. I added a try-except block in the carbontracker usage but it seems is not enough. Any ideas ? |
Signed-off-by: Mario Dominguez <[email protected]>
b758a51
to
07d8856
Compare
This PR should be merged after: